-
Notifications
You must be signed in to change notification settings - Fork 544
Re-enable webhooks sidebar link in project dashboard #7196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable webhooks sidebar link in project dashboard #7196
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes update webhook API calls to explicitly use the HTTPS scheme, re-enable the "Webhooks" sidebar link in the dashboard UI, and refine the type of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DashboardUI
participant WebhookAPI
User->>DashboardUI: Clicks "Webhooks" in sidebar
DashboardUI->>WebhookAPI: fetch('https://<API_DOMAIN>/webhooks', ...)
WebhookAPI-->>DashboardUI: Returns webhook data
DashboardUI-->>User: Displays webhooks
Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7196 +/- ##
=======================================
Coverage 55.68% 55.68%
=======================================
Files 904 904
Lines 58392 58392
Branches 4122 4122
=======================================
Hits 32516 32516
Misses 25770 25770
Partials 106 106
🚀 New features to boost your workflow:
|
size-limit report 📦
|
467d4bf
to
f3aebed
Compare
f3aebed
to
a58e480
Compare
a58e480
to
e6a5fc4
Compare
Merge activity
|
## [Dashboard] Feature: Add Webhooks to Project Sidebar ## Notes for the reviewer This PR adds the Webhooks option to the project sidebar navigation. The option was previously commented out due to a scrolling issue, which has now been resolved. ## How to test Navigate to a project page and verify that the Webhooks option appears in the sidebar with a "New" badge. <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on refining the handling of webhook payloads and enhancing the `ProjectSidebarLayout` component by reintroducing the webhooks link. It also updates the API fetch calls to ensure they consistently use HTTPS. ### Detailed summary - Changed `params` type in `webhookPayloadUtils.ts` from `Record<string, unknown> | unknown[]` to `Record<string, unknown>`. - Updated `params` in the `buildTransactionWebhookPayload` function to use an empty object instead of an empty array. - Reintroduced the webhooks link in `ProjectSidebarLayout.tsx` with appropriate properties. - Updated fetch calls in `webhooks.ts` to use HTTPS for the API domain in multiple functions (`getWebhooks`, `deleteWebhook`, `testWebhook`). > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Re-enabled the "Webhooks" link in the project sidebar, now visible with a "New" badge. - **Bug Fixes** - Improved API reliability by ensuring all webhook-related network requests use the correct HTTPS scheme. - **Refactor** - Updated internal data structures for webhook payloads to improve consistency and type safety. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
e6a5fc4
to
cb994dc
Compare
[Dashboard] Feature: Add Webhooks to Project Sidebar
Notes for the reviewer
This PR adds the Webhooks option to the project sidebar navigation. The option was previously commented out due to a scrolling issue, which has now been resolved.
How to test
Navigate to a project page and verify that the Webhooks option appears in the sidebar with a "New" badge.
PR-Codex overview
This PR focuses on refining the webhook functionality within the application by updating types, improving API fetch calls with secure URLs, and enhancing the sidebar component to include a Webhooks link.
Detailed summary
params
type inwebhookPayloadUtils.ts
fromunknown[]
toRecord<string, unknown>
.params
initialization from an empty array[]
to an empty object{}
inbuildTransactionWebhookPayload
.BellIcon
and reintroduced the Webhooks link inProjectSidebarLayout.tsx
.webhooks.ts
to use secure URLs (https://
).webhooks.ts
.Summary by CodeRabbit
New Features
Bug Fixes
Refactor